Skip to content

[py][bidi]: skip test_perform_actions_pointer_pen_type for firefox#17203

Merged
cgoldberg merged 3 commits intoSeleniumHQ:trunkfrom
navin772:xfail-firefox-pen-type
Mar 13, 2026
Merged

[py][bidi]: skip test_perform_actions_pointer_pen_type for firefox#17203
cgoldberg merged 3 commits intoSeleniumHQ:trunkfrom
navin772:xfail-firefox-pen-type

Conversation

@navin772
Copy link
Member

🔗 Related Issues

💥 What does this PR do?

Skips the test_perform_actions_pointer_pen_type test for firefox as it is not yet implemented, returns error -
Error: Unimplemented pointerMove for pointerType pen

WPT tests - https://wpt.fyi/results/webdriver/tests/bidi/input/perform_actions/pointer_pen.py?label=master&label=stable&product=firefox&product=chrome&product=edge&aligned

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Tests

Copilot AI review requested due to automatic review settings March 11, 2026 05:37
@qodo-code-review
Copy link
Contributor

Review Summary by Qodo

Skip pointer pen type test for Firefox due to unimplemented feature

🧪 Tests

Grey Divider

Walkthroughs

Description
• Skip test_perform_actions_pointer_pen_type test for Firefox
• Mark test with @pytest.mark.xfail_firefox decorator
• Firefox does not yet support pointer pen type actions

Grey Divider

File Changes

1. py/test/selenium/webdriver/common/bidi_input_tests.py 🧪 Tests +1/-0

Mark pen pointer test as expected failure for Firefox

• Added @pytest.mark.xfail_firefox decorator to test_perform_actions_pointer_pen_type test
• Marks test as expected to fail on Firefox browser
• Firefox currently returns "Unimplemented pointerMove for pointerType pen" error

py/test/selenium/webdriver/common/bidi_input_tests.py


Grey Divider

Qodo Logo

@selenium-ci selenium-ci added the C-py Python Bindings label Mar 11, 2026
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Mar 11, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Xfail missing reason 🐞 Bug ✧ Quality
Description
test_perform_actions_pointer_pen_type is marked xfail_firefox without a reason, so test output won’t
document why the test is disabled for Firefox and makes it harder to track when it should be
re-enabled.
Code

py/test/selenium/webdriver/common/bidi_input_tests.py[532]

+@pytest.mark.xfail_firefox
Evidence
The PR adds an xfail_firefox marker with no kwargs, while the same test module uses
xfail_firefox(reason=...) for other Firefox-unimplemented BiDi behaviors. In this repo, xfail_*
markers are converted into pytest.xfail(**marker.kwargs) during driver fixture setup, so the
marker’s reason is the primary documentation emitted in reports.

py/test/selenium/webdriver/common/bidi_input_tests.py[526-535]
py/test/selenium/webdriver/common/bidi_input_tests.py[360-362]
py/test/selenium/webdriver/common/bidi_input_tests.py[396-398]
py/conftest.py[426-444]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`test_perform_actions_pointer_pen_type` is marked `@pytest.mark.xfail_firefox` without a `reason`, so pytest reports provide no context for why the test is xfailed.

### Issue Context
This repo translates `xfail_*` markers into `pytest.xfail(**marker.kwargs)` in `py/conftest.py`, so the marker’s kwargs (especially `reason`) are what show up in results and become the main durable documentation.

### Fix Focus Areas
- py/test/selenium/webdriver/common/bidi_input_tests.py[532-533]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Marks the BiDi input pen-pointer actions test as an expected Firefox failure to reflect the current lack of implementation for pointerType=pen in Firefox.

Changes:

  • Add a Firefox-specific xfail marker to test_perform_actions_pointer_pen_type.

@navin772 navin772 enabled auto-merge (squash) March 11, 2026 05:49
Copilot AI review requested due to automatic review settings March 13, 2026 14:10
@navin772 navin772 disabled auto-merge March 13, 2026 14:10
@navin772
Copy link
Member Author

@cgoldberg could you merge this, I only see Enable auto merge

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@cgoldberg cgoldberg merged commit 7cebc10 into SeleniumHQ:trunk Mar 13, 2026
32 of 33 checks passed
@cgoldberg
Copy link
Member

@navin772 done. It wouldn't let me until I resolved all conversations

@navin772 navin772 deleted the xfail-firefox-pen-type branch March 13, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants